Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Elixir root module suggestions #236

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

Goose97
Copy link
Contributor

@Goose97 Goose97 commented Jul 13, 2023

Fixes #230

@Goose97 Goose97 force-pushed the fix/elixir-module-complete branch from 3ed7deb to ff3338c Compare July 13, 2023 05:01
@lukaszsamson
Copy link
Collaborator

In #230 I was more concerned on why it aliases Elixir. I fixed that on master as well as some other issues in the required_alias.

Regarding your changes I'd like to preserve this module as close to iex as possible. https://github.com/elixir-lang/elixir/blob/5a5947c2d917f519e9a22ec069538106ff9378a0/lib/iex/lib/iex/autocomplete.ex#L563
Can you make a more limited change that only modifies the full name?

@Goose97
Copy link
Contributor Author

Goose97 commented Jul 13, 2023

Regarding your changes I'd like to preserve this module as close to iex as possible. https://github.com/elixir-lang/elixir/blob/5a5947c2d917f519e9a22ec069538106ff9378a0/lib/iex/lib/iex/autocomplete.ex#L563 Can you make a more limited change that only modifies the full name?

Sure, that makes sense.

@Goose97 Goose97 force-pushed the fix/elixir-module-complete branch from ff3338c to c927431 Compare July 13, 2023 07:10
@lukaszsamson lukaszsamson merged commit da9ced6 into elixir-lsp:master Jul 13, 2023
22 of 23 checks passed
@lukaszsamson
Copy link
Collaborator

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Elixir proxy completion adds alias
2 participants